Skip to content

TST: update xfail xarray version check in to_xarray test #61648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

jorisvandenbossche
Copy link
Member

Started to see xpass in #61594, so updating the version check here. Not sure this is entirely covered by CI, but tested this locally with a few different xarray versions.

@jorisvandenbossche jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Jun 13, 2025
@jorisvandenbossche jorisvandenbossche added this to the 2.3.1 milestone Jun 13, 2025
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jorisvandenbossche for taking care of this

@datapythonista datapythonista merged commit 7def76a into pandas-dev:main Jun 13, 2025
48 checks passed
Copy link

lumberbot-app bot commented Jun 13, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 7def76a79361c8f6aa2893d9a559da03c6cb6d3a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61648: TST: update xfail xarray version check in to_xarray test'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61648-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #61648 on branch 2.3.x (TST: update xfail xarray version check in to_xarray test)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Backport -> #61652

jorisvandenbossche added a commit that referenced this pull request Jun 13, 2025
…test (#61648) (#61652)

TST: update xfail xarray version check in to_xarray test (#61648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants