Skip to content

check if changing .pxd causes build issues #58585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

check if changing .pxd causes build issues #58585

wants to merge 1 commit into from

Conversation

undermyumbrella1
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@undermyumbrella1 undermyumbrella1 requested a review from WillAyd as a code owner May 6, 2024 08:41
@undermyumbrella1 undermyumbrella1 marked this pull request as draft May 6, 2024 08:41
@phofl
Copy link
Member

phofl commented May 6, 2024

Please open issues first before doing changes like this

@phofl phofl closed this May 6, 2024
@undermyumbrella1 undermyumbrella1 deleted the perf/first-last-fallback-to-apply-binary-eas branch May 6, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@undermyumbrella1 @phofl