Skip to content

[backport 2.3.x] TST: update xfail xarray version check in to_xarray test (#61648) #61652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Backport of #61648

Probably not needed to backport because we might not get the latest xarray versions in the envs of the 2.3.x branch, but still useful in case someone runs the tests with more up to date xarray

@jorisvandenbossche jorisvandenbossche added this to the 2.3.1 milestone Jun 13, 2025
@jorisvandenbossche jorisvandenbossche changed the title TST: update xfail xarray version check in to_xarray test (#61648) [backport 2.3.x] TST: update xfail xarray version check in to_xarray test (#61648) Jun 13, 2025
@datapythonista
Copy link
Member

Not sure why we get the failures in the CI, I don't think they happen in main. And I don't remember any recent PR fixing those.

@jorisvandenbossche
Copy link
Member Author

Not sure why we get the failures in the CI, I don't think they happen in main.

Currently it is the python-dev windows one that is failing. It has been failing consistently the last few days while I have been doing backports.
Quickly checking, this was not yet failing last week when the 2.3.0 release was done. Comparing that build with the first failing one of this week, there are various things that updated. It's a newer version of the image, python updated from 3.13.3 to 3.13.4, cython updated from 3.1.1 to 3.1.2.

What seems fishy is that the error message is saying "LINK : fatal error LNK1104: cannot open file 'python313t.lib'", but this is not for a free-threaded build.

Now, it seems that Python 3.13.4 has several unintended regressions, which are fixed in 3.13.5 (https://www.python.org/downloads/release/python-3135/, one related to building on windows), so it is probably just a matter of waiting until we get 3.13.5 through the setup action.

@jorisvandenbossche
Copy link
Member Author

And the reason it is not failing on main is because there 3.13 is tested through a conda env (#61333), and conda-forge directly updated from 3.13.3 to 3.13.5, avoiding the issue

@jorisvandenbossche jorisvandenbossche merged commit 6c85d11 into pandas-dev:2.3.x Jun 13, 2025
43 of 45 checks passed
@jorisvandenbossche jorisvandenbossche deleted the backport-61648 branch June 13, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants