GH1248/GH1249 DataFrame.assign and MultiIndex.from_product Series/Index #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Jun 13, 2025
| AnyArrayLike | Scalar | Callable[[DataFrame], AnyArrayLike | Scalar] | None | ||
| AnyArrayLike | ||
| | Scalar | ||
| | Callable[[DataFrame], AnyArrayLike | Scalar | list[Scalar] | range] |
There was a problem hiding this comment.
Suggested change
| | Callable[[DataFrame], AnyArrayLike | Scalar | list[Scalar] | range] | |
| | Callable[[DataFrame], AnyArrayLike | Scalar | list[Scalar] | range] | | |
| list[Scalar] | range |
tests/test_indexes.py
Outdated
Comment on lines
65
to
66
| mi = pd.MultiIndex.from_product([["x", "y"], df.columns]) | ||
| mi = pd.MultiIndex.from_product([["x", "y"], pd.Series([1, 2])]) |
There was a problem hiding this comment.
can you add the check(assert_type( pattern here?
tests/test_frame.py
Outdated
| df = pd.DataFrame({"a": [1, 2, 3]}) | ||
| check( | ||
| assert_type( | ||
| df.assign(b=lambda df: range(len(df)), c=lambda df: [10, 20, 30]), |
There was a problem hiding this comment.
also want to test df.assign(b=range(len(df)), c=[10,20,30])
loicdiridollou
force-pushed
the
gh1248_df_assign
branch
from
5fd69f7 to
c118810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.assign()should allow a list and a range #1248 andMultiIndex.from_product()should acceptIndexorSeriesas arguments #1249assert_type()to assert the type of any return value