Skip to content

Upgrade deploy #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

AndrewQuijano
Copy link
Collaborator

@AndrewQuijano AndrewQuijano commented Dec 7, 2024

Hello,
This should be covering the last batch of chances to publishing GitHub action.

  1. First, avoid publishing the same artifact twice, which caused an issue with the release that occurred last deployment

Already fixed here: #1522

  1. Changing the workflow to fix Version disconnects between deb and python packages #1501 Essentially, having the first step be uploading to PyPi, this should enforce that the versions between releases and pip will be aligned permanently. If the PyPi upload fails, there will be no release created.

I should note, I believe you'd need to manually upload 1.8.28 and 1.8.35 to PyPi, not sure if you'd want to also delete 1.8.22.dev12 and 1.8.21.dev1 from PyPi, but this should hopefully make sure Pip is retroactively fixed to be in lock step after version 1.8.21

https://pypi.org/project/pandare/#history

  1. Swap order of containers being built, so we can leverage caching for faster publishing of pandadev and panda containers.

  2. I also removed duplicate code in regard to updating documentation used on both dev and stable branches.

To confirm this works, changing Python code causes a new commit created here in documentation step
https://github.com/panda-re/panda-re.github.io/commits/master/

Testing:
I confirmed this approach of publish to pypi then release works, see code and action:

https://github.com/AndrewQuijano/Treespace_REU_2017/blob/main/.github/workflows/deploy_wheel.yml

https://github.com/AndrewQuijano/Treespace_REU_2017/actions/runs/14785728543/job/41513678740

As for the code de-duplication, I followed the steps done on the dev branch, the only difference instead of hard coding dev it points to ${{ github.ref_name }}

@AndrewQuijano AndrewQuijano force-pushed the upgrade-deploy branch 5 times, most recently from 10ad8cd to b0dab17 Compare May 4, 2025 17:09
@AndrewQuijano AndrewQuijano force-pushed the upgrade-deploy branch 3 times, most recently from 26803c0 to ef622ff Compare May 15, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version disconnects between deb and python packages
1 participant