-
-
Couldn't load subscription status.
- Fork 19
feat: added ascii option
#995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 83.43% 84.28% +0.85%
==========================================
Files 47 47
Lines 12604 13025 +421
==========================================
+ Hits 10516 10978 +462
+ Misses 2088 2047 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c2fdb0 to
516657d
Compare
2be7665 to
cfd1d10
Compare
a62fdb0 to
4fc29e3
Compare
0094a88 to
712fa24
Compare
bef44fa to
c03d837
Compare
a5081d3 to
12dd0d5
Compare
e58a43c to
03bbe27
Compare
cba828e to
6dfd526
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds ASCII mode functionality to the log formatting system, allowing users to control whether Unicode or ASCII-only characters are used in punctuation marks throughout log output.
Key changes include:
- Added
AsciiModeOptenum for configuration with Auto/Always/Never options - Introduced
DisplayVarianttype for dual ASCII/Unicode representation of punctuation - Updated all punctuation fields to support both ASCII and Unicode variants
- Modified the formatter pipeline to resolve punctuation based on ASCII mode setting
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/settings.rs | Core ASCII mode types, DisplayVariant enum, and updated Punctuation struct |
| src/formatting.rs | RecordFormatterBuilder pattern and ASCII-aware formatting logic |
| src/main.rs | UTF-8 detection and ASCII mode resolution in main application flow |
| src/cli.rs | Command-line interface for ASCII option with enum conversions |
| src/app.rs | Application-level ASCII mode handling and formatter integration |
| etc/defaults/config.yaml | Default configuration with ASCII/Unicode punctuation variants |
| schema/json/config.schema.json | JSON schema updates for DisplayVariant validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.