Skip to content

Conversation

@pamburus
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.28%. Comparing base (df18197) to head (ecaeddd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   83.43%   84.28%   +0.85%     
==========================================
  Files          47       47              
  Lines       12604    13025     +421     
==========================================
+ Hits        10516    10978     +462     
+ Misses       2088     2047      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment was marked as outdated.

This comment was marked as outdated.

@pamburus pamburus force-pushed the feature/ascii branch 2 times, most recently from a62fdb0 to 4fc29e3 Compare August 19, 2025 23:20
@pamburus pamburus requested a review from Copilot August 19, 2025 23:21

This comment was marked as outdated.

@pamburus pamburus force-pushed the feature/ascii branch 2 times, most recently from 0094a88 to 712fa24 Compare August 25, 2025 18:41
@pamburus pamburus requested a review from Copilot August 25, 2025 18:42

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot August 25, 2025 18:49

This comment was marked as outdated.

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot August 25, 2025 19:09
@pamburus pamburus force-pushed the feature/ascii branch 2 times, most recently from e58a43c to 03bbe27 Compare August 25, 2025 21:01
@pamburus pamburus marked this pull request as draft August 25, 2025 21:06
@pamburus pamburus closed this Aug 25, 2025
@pamburus pamburus review requested due to automatic review settings August 25, 2025 21:07
@pamburus pamburus reopened this Aug 25, 2025
@pamburus pamburus requested a review from Copilot August 25, 2025 21:07
@pamburus pamburus marked this pull request as ready for review August 25, 2025 21:07

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot September 3, 2025 19:41

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot September 3, 2025 20:06

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot September 3, 2025 20:26

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot September 3, 2025 20:38

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot September 3, 2025 21:15

This comment was marked as outdated.

pamburus and others added 2 commits September 3, 2025 23:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pamburus pamburus requested a review from Copilot September 3, 2025 21:20

This comment was marked as outdated.

@pamburus pamburus requested a review from Copilot September 3, 2025 21:33

This comment was marked as outdated.

pamburus and others added 2 commits September 3, 2025 23:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pamburus pamburus requested a review from Copilot September 3, 2025 21:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds ASCII mode functionality to the log formatting system, allowing users to control whether Unicode or ASCII-only characters are used in punctuation marks throughout log output.

Key changes include:

  • Added AsciiModeOpt enum for configuration with Auto/Always/Never options
  • Introduced DisplayVariant type for dual ASCII/Unicode representation of punctuation
  • Updated all punctuation fields to support both ASCII and Unicode variants
  • Modified the formatter pipeline to resolve punctuation based on ASCII mode setting

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/settings.rs Core ASCII mode types, DisplayVariant enum, and updated Punctuation struct
src/formatting.rs RecordFormatterBuilder pattern and ASCII-aware formatting logic
src/main.rs UTF-8 detection and ASCII mode resolution in main application flow
src/cli.rs Command-line interface for ASCII option with enum conversions
src/app.rs Application-level ASCII mode handling and formatter integration
etc/defaults/config.yaml Default configuration with ASCII/Unicode punctuation variants
schema/json/config.schema.json JSON schema updates for DisplayVariant validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pamburus pamburus merged commit 72a32a9 into master Sep 3, 2025
12 checks passed
@pamburus pamburus deleted the feature/ascii branch September 3, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants