Feat/Update-HEIs-without-dna-pcr-results-Indicator-to-have-HEis-turning-8-weeks-only in assessment period

[nobert-mumo]

Jira ticket: https://thepalladiumgroup.atlassian.net/browse/KHP3-8657

Summary by Sourcery

Enhancements:

• Restrict assessment period to the 8-week birthday for the HEIs without DNA PCR results indicator

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the HEI aggregate query to only consider infants at exactly eight weeks, simplifying the CTE and updating downstream references accordingly.

Entity Relationship diagram for updated HEI aggregate query

erDiagram
    HEIS {
        string client_id
        date dob
        string mfl_code
        string sex
    }
    HEIS_8_WEEKS_BIRTHDAY {
        string client_id
        date dob
        string mfl_code
        string sex
        date eight_weeks_birthday
    }
    HEISWITHOUTDNAPCR {
        string client_id
        string mfl_code
    }
    MFL_PARTNER_AGENCY_COMBINATION {
        string mfl_code
        string County
        string SubCounty
        string PartnerName
        string Agency
        string FacilityName
    }
    CSRTAggregateHeisWithoutDnaPcr {
        string County
        string SubCounty
        string PartnerName
        string Agency
        string FacilityName
        date AssessmentPeriod
        string MFLCode
        string Sex
        int TotalHeis
        int TotalHeiWithoutDnaPcr
        string Indicator
        date LoadDate
    }
    HEIS ||--o| HEIS_8_WEEKS_BIRTHDAY : "generates"
    HEIS_8_WEEKS_BIRTHDAY ||--o| HEISWITHOUTDNAPCR : "left join"
    HEIS_8_WEEKS_BIRTHDAY ||--o| MFL_PARTNER_AGENCY_COMBINATION : "left join"
    HEIS_8_WEEKS_BIRTHDAY ||--o| CSRTAggregateHeisWithoutDnaPcr : "aggregates into"

Loading

Class diagram for updated CTE and downstream references

classDiagram
    class HEIS {
        +client_id: string
        +dob: date
        +mfl_code: string
        +sex: string
    }
    class HEIS_8_WEEKS_BIRTHDAY {
        +client_id: string
        +dob: date
        +mfl_code: string
        +sex: string
        +eight_weeks_birthday: date
    }
    HEIS --|> HEIS_8_WEEKS_BIRTHDAY : derives
    class CSRTAggregateHeisWithoutDnaPcr {
        +County: string
        +SubCounty: string
        +PartnerName: string
        +Agency: string
        +FacilityName: string
        +AssessmentPeriod: date
        +MFLCode: string
        +Sex: string
        +TotalHeis: int
        +TotalHeiWithoutDnaPcr: int
        +Indicator: string
        +LoadDate: date
    }
    HEIS_8_WEEKS_BIRTHDAY --> CSRTAggregateHeisWithoutDnaPcr : aggregates
    class HEISWITHOUTDNAPCR {
        +client_id: string
        +mfl_code: string
    }
    HEIS_8_WEEKS_BIRTHDAY --> HEISWITHOUTDNAPCR : left join
    class MFL_PARTNER_AGENCY_COMBINATION {
        +mfl_code: string
        +County: string
        +SubCounty: string
        +PartnerName: string
        +Agency: string
        +FacilityName: string
    }
    HEIS_8_WEEKS_BIRTHDAY --> MFL_PARTNER_AGENCY_COMBINATION : left join

Loading

File-Level Changes

Change	Details	Files
Focus assessment period on 8-week birthdays only	Removed union of 6- and 7-week birthday CTEs Condensed to a single CTE computing only the 8-week birthday	Scripts/REPORTING/HIVCaseSurveillance/RealtimeData/1_load_cs_aggregate_heis_without_dna_pcr_results.sql
Rename CTE and birthday alias for clarity	Renamed CTE to heis_8_weeks_birthday Changed dateadd alias from birthday to eight_weeks_birthday	Scripts/REPORTING/HIVCaseSurveillance/RealtimeData/1_load_cs_aggregate_heis_without_dna_pcr_results.sql
Update main query to use new CTE and alias	Replaced SELECT references from old CTE/alias to new names Adjusted JOIN and GROUP BY clauses to reference heis_8_weeks_birthday and eight_weeks_birthday	Scripts/REPORTING/HIVCaseSurveillance/RealtimeData/1_load_cs_aggregate_heis_without_dna_pcr_results.sql

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}