Added the linelist FactART on the Archive

[DennisGibz]

Summary by Sourcery

Enhancements:

• Add a SQL archive script that inserts Linelist_FACTART data from the reporting schema into the Historical.dbo.Linelist_FACTART table with a load timestamp

[sourcery-ai]

Reviewer's Guide

Add a new ETL script that archives the Linelist_FACTART table from the reporting schema into the historical schema by performing a full insert-select with column mappings and load metadata.

File-Level Changes

Change	Details	Files
Introduce archive script for Linelist_FACTART	Create new SQL file with insert-select into Historical.dbo.Linelist_FACTART Map all source columns one-to-one from REPORTING.dbo.Linelist_FACTART Generate LoadDate using GETDATE() and map EndOfMonthDate to AsOfDate Adjust renames: Sex→Gender and ARTOutcomeDescription→ARTOutcome	Scripts/REPORTING/SCHEMA/2_Archive_Linelist_FACTART.sql

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @DennisGibz - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `Scripts/REPORTING/SCHEMA/2_Archive_Linelist_FACTART.sql:108` </location>
<code_context>
+ 
+ SELECT  [PatientIDHash]
+      ,[PatientPKHash]
+      ,[Sex]
+      ,[DOB]
+      ,[MaritalStatus]
</code_context>

<issue_to_address>
Column mapping mismatch: 'Gender' vs 'Sex'.

Ensure the column names in the insert and select statements match to prevent data insertion errors.
</issue_to_address>

### Comment 2
<location> `Scripts/REPORTING/SCHEMA/2_Archive_Linelist_FACTART.sql:207` </location>
<code_context>
+      ,[OnTBTreatment]
+      ,[TPTInitiationDate]
+      ,[CareGiverLastVL]
+      ,[EndofMonthDate]
+	  ,GetDate()
+  FROM [REPORTING].[dbo].[Linelist_FACTART]
</code_context>

<issue_to_address>
Column mapping mismatch: 'AsOfDate' vs 'EndofMonthDate'.

Please confirm that mapping 'EndofMonthDate' to 'AsOfDate' is correct and maintains the intended data meaning.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Column mapping mismatch: 'Gender' vs 'Sex'.

Ensure the column names in the insert and select statements match to prevent data insertion errors.

[sourcery-ai]

issue (bug_risk): Column mapping mismatch: 'AsOfDate' vs 'EndofMonthDate'.

Please confirm that mapping 'EndofMonthDate' to 'AsOfDate' is correct and maintains the intended data meaning.

[nobert-mumo]

@DennisGibz
I thought we would implement similar to this https://github.com/palladiumkenya/dwh-etl/blob/dev/Scripts/NDWH/C%26T%20FACT%20TABLES/2_FactART_Historical_Snapshot.sql ?

To take care of when we run the pipelines multiple times a month to avoid duplicating the table.

[DennisGibz]

@nobert-mumo this is for the linelist not the fact. The process exists but manual.

[nobert-mumo]

@DennisGibz not sure I get it. I meant we should consider implementing the historical of the linelist in a similar way we did for the fact

[nobert-mumo]

@DennisGibz not sure I get it. I meant we should consider implementing the historical of the linelist in a similar way we did for the fact

@DennisGibz

[DennisGibz]

@nobert-mumo ,yes I agree with you. Above is now well factored in.