Feat: Add column TotalPatients to CsAggregateMortalityAndHIVDeaths

[kevlanyo]

• Add new CTE PatientsData to contain a count of patients per facility by age group
• Link the new CTE to PatientExits to generate a TotalPatients value per facility per age group

@sourcery-ai review

Summary by Sourcery

New Features:

• Adds a TotalPatients column to the CsAggregateMortalityAndHIVDeaths table.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new column, TotalPatients, to the CsAggregateMortalityAndHIVDeaths table. It calculates the total number of patients per facility and age group using a new CTE called PatientsData, and then integrates this data into the final SELECT statement.

ER diagram for CsAggregateMortalityAndHIVDeaths table changes

erDiagram
    CsAggregateMortalityAndHIVDeaths {
        varchar FacilityName
        int MFLCode
        varchar PartnerName
        varchar AgencyName
        datetime ExitDate
        varchar CohortYearMonth
        varchar AgeGroup
        int TotalPatients
        int NoOfDeaths
        int NoOfHIVDeaths
    }
    FACTART {
        int PatientKey
        int FacilityKey
        int AgeGroupKey
    }
    Dimagegroup {
        int AgeGroupKey
        varchar Datimagegroup
    }
    PatientExits {
        int PatientKey
        int FacilityKey
        datetime ExitDate
        varchar CohortYearMonth
        int Age
    }
    CsAggregateMortalityAndHIVDeaths ||--|| DimFacility : has
    CsAggregateMortalityAndHIVDeaths ||--|| DimPartner : has
    CsAggregateMortalityAndHIVDeaths ||--|| DimAgency : has
    FACTART }o--|| Dimagegroup : has
    PatientExits }o--|| FACTART : has

Loading

File-Level Changes

Change	Details	Files
Introduced a new CTE to calculate the total number of patients per facility, grouped by age.	Created a PatientsData CTE to count distinct patients per facility and age group. Grouped the patient counts by FacilityKey and Datimagegroup.	Scripts/REPORTING/HIVCaseSurveillance/load_cs_aggregate_mortality_and_hiv_related_deaths.sql
Integrated the new patient count data into the final SELECT statement to include TotalPatients in the output.	Joined PatientsData CTE with the main query using FacilityKey and Datimagegroup. Added Patients.TotalPatients to the SELECT statement to include it in the result set. Included Patients.TotalPatients in the GROUP BY clause.	Scripts/REPORTING/HIVCaseSurveillance/load_cs_aggregate_mortality_and_hiv_related_deaths.sql

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @kevlanyo - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why Age.Age is used in the join to PatientExits instead of Age.AgeGroupKey.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[nobert-mumo]

@kevlanyo I think this is related to the CS review discussions. I think we would need to start with the FactARTHistory to have patients cohort totals at each month and then join on died cohorts for each month.

[Marymary-dev]

Exactly, @kevlanyo the FactART is a fact that represents data as of last completed month and therefore we will only have one denominator as opposed to the Fact ART History which we can get totals asof dates since we are plotting a trendline