Skip to content

Expose properties in BaseDistributionExtension #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Expose properties in BaseDistributionExtension #1755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
303697b
acp
kamilk-pal Dec 19, 2024
48c88b8
fix formatting
kamilk-pal Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions gradle-sls-packaging/src/main/java/com/palantir/gradle/dist/BaseDistributionExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import groovy.lang.DelegatesTo;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import javax.inject.Inject;
Expand Down Expand Up @@ -92,7 +91,7 @@ public BaseDistributionExtension(Project project) {
projectName = project.getName();
}

public final Provider<String> getDistributionServiceGroup() {
public final Property<String> getDistributionServiceGroup() {
return serviceGroup;
}

Expand All @@ -110,7 +109,7 @@ public final void setServiceGroup(String serviceGroup) {
this.serviceGroup.set(serviceGroup);
}

public final Provider<String> getDistributionServiceName() {
public final Property<String> getDistributionServiceName() {
return serviceName;
}

Expand All @@ -128,7 +127,7 @@ public final void setServiceName(String serviceName) {
this.serviceName.set(serviceName);
}

public final Provider<ProductType> getProductType() {
public final Property<ProductType> getProductType() {
return productType;
}

Expand Down Expand Up @@ -230,7 +229,7 @@ public final void productDependency(@DelegatesTo(ProductDependency.class) Closur
}));
}

public final Provider<Set<ProductId>> getOptionalProductDependencies() {
public final SetProperty<ProductId> getOptionalProductDependencies() {
return optionalProductDependencies;
}

Expand All @@ -242,7 +241,7 @@ public final void optionalProductDependency(String optionalProductId) {
this.optionalProductDependencies.add(new ProductId(optionalProductId));
}

public final Provider<Set<ProductId>> getIgnoredProductDependencies() {
public final SetProperty<ProductId> getIgnoredProductDependencies() {
return ignoredProductDependencies;
}

Expand Down