Skip to content

Requiring python during build time in case is not available on the build image #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2025
Merged

Requiring python during build time in case is not available on the build image #1318

merged 4 commits into from
Oct 12, 2025

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Oct 3, 2025 •
edited
Loading

Merge After

paketo-buildpacks/nodejs#1215

Summary

This PR requires cpython for installing python binaries in non rhel distributions, as the base build image does not include python on non rhel distributions. This is necessary for npm-install in case it has to compile native modules.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner October 3, 2025 15:15
@pacostas pacostas added the semver:minor A change requiring a minor version bump label Oct 3, 2025
@pacostas pacostas force-pushed the excluding-installing-python branch from a1c2ed6 to 47aecbb Compare October 3, 2025 16:54
@pacostas pacostas force-pushed the excluding-installing-python branch 3 times, most recently from bbb539a to f548b84 Compare October 11, 2025 10:54
@pacostas pacostas changed the title Requiring python during build time for non rhel distributions Requiring python during build time in case is not available on the build image Oct 11, 2025
@pacostas pacostas force-pushed the excluding-installing-python branch from f548b84 to 469da15 Compare October 11, 2025 13:04
jericop
jericop requested changes Oct 12, 2025
View reviewed changes
@pacostas pacostas enabled auto-merge (squash) October 12, 2025 13:37
@pacostas pacostas merged commit f0dd5e9 into paketo-buildpacks:main Oct 12, 2025
10 checks passed
@pacostas pacostas mentioned this pull request Oct 16, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jericop jericop jericop approved these changes

@mhdawson mhdawson Awaiting requested review from mhdawson mhdawson is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees

No one assigned

Labels

semver:minor A change requiring a minor version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pacostas @jericop