-
Notifications
You must be signed in to change notification settings - Fork 27
Add ARM dependencies #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ARM dependencies #1145
Conversation
@paketo-buildpacks/nodejs-maintainers Probably some adjustment to dependabot are needed. Could you give me some guidance? |
@pacostas I think you know the most about freezer so maybe you can take the first look. |
Nice! I think it would be good to apply the multi-arch changes too by following what has been changed on below two PRs:
You will also see on the buildpack.toml file, that is specified the include-files, pre-package and the target attributes. These are necessary for jam and pack, to know what to package. If you apply the multi-arch changes, then I can run it locally and see what is failing as there are a lot of chances that the error might be due pack does not match properly the arm assets. |
see 93da5f2 |
I am starting to understand the |
The plan is to sync all the scripts on github-config and remove them from |
"linux/amd64/bin/detect", | ||
"linux/amd64/bin/run", | ||
"linux/amd64/bin/optimize-memory, | ||
"linux/amd64/bin/inspector, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is a double quote missing here.
Are there any errors that pack throws after fixing the double quote?
@c0d1ngm0nk3y This PR is superseded by this one #1293 |
Prerequisite: New
packit
release must be consumed to handle the same dependencies with different architectures.Summary
Adding
arm
dependencies for downloadUse Cases
I want to build an
arm
image.Checklist