feat: remove deprecated bionic stack and add noble #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bionic stack is deprecated and no Node.js no longer builds for it with default tools, remove it. Add noble stack Signed-off-by: Michael Dawson <mdawson@devrus.com>
pacostas
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
LGTM adding it on the dependencies and remove the deprecated one (bionic). Also it will not fix the issue with the node compilation but it will give us a better understanding on how the workflow works and also this issue is not related to this PR so with a subsequent one we can replace the bionic.dockerfile with a proper one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bionic stack is deprecated and no Node.js no longer builds for it with default tools, remove it.
Add noble stack
This should fix: #617 as we only compile Node right now on bionic.
It think it will also obsolete #585 since we won't be compiling node.js anymore.
Use Cases
Checklist