Skip to content

chore!: [SIW-2111] Remove deprecated code from WIA 0.7.1 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Jun 4, 2025

List of Changes

  • Removed code from the older Wallet Instance Attestation implementation

Motivation and Context

This PR removes code that handles the issuing of the old Wallet Attestation, so that only the 1.0 specs are supported.

Note

This change is the first breaking change introduced in the master branch, marking the start of the separation between 0.7.1-compatible and 1.0-compatible implementations. From now on, only 1.0 implementations will be merged into master, superseding the older code.

Warning

The last version of io-react-native-wallet compatible with 0.7.1 specs ("Documenti su IO") will be 0.30.0.

How Has This Been Tested?

Create a new Wallet Instance and get the attestation. Everything should work as before.

Note that PID/EAA issuing will not work anymore until #217 and #219 will be merged.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gispada gispada requested a review from a team as a code owner June 4, 2025 10:38
@gispada gispada changed the title chore: [SIW-2111] Remove deprecated code from WIA 0.7.1 chore!: [SIW-2111] Remove deprecated code from WIA 0.7.1 Jun 4, 2025
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything works as expected

@gispada gispada merged commit b98a261 into master Jun 6, 2025
7 checks passed
@gispada gispada deleted the SIW-2111-remove-deprecated-code branch June 6, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants