Skip to content

Conversation

fwimp
Copy link
Contributor

@fwimp fwimp commented Jul 30, 2025

This PR implements the fitting functions suggested in #77 and #78.

It adds 1 new dependency (glue) however this is a free dep as cli already depends upon it.

Parallel fitting requires purrr >= v1.1.0, however this is implemented as an optional feature rather than a full dependency.

@fwimp fwimp mentioned this pull request Jul 30, 2025
@fwimp
Copy link
Contributor Author

fwimp commented Jul 30, 2025

Woops, got some R CMD CHECK things to fix quickly

@fwimp
Copy link
Contributor Author

fwimp commented Jul 30, 2025

Better now, but still 2 warnings and 2 notes:

N  checking R code for possible problems (5.2s)
   quickfit_tpc_multi: no visible binding for global variable 'data'
   quickfit_tpc_multi: no visible binding for global variable 'mods'
   Undefined global functions or variables:
     data mods
   Consider adding
     importFrom("utils", "data")
   to your NAMESPACE file.
W  checking for unstated dependencies in examples (544ms)
   'library' or 'require' call not declared from: 'ggplot2'
W  checking for unstated dependencies in 'tests' (4.9s)
   'library' or 'require' call not declared from: 'ggplot2'

Not deal-breakers for sure but those notes are usually a pain to fix. I'll have a look when I'm not travelling

@padpadpadpad padpadpadpad merged commit d7e7e6d into padpadpadpad:master Jul 31, 2025
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants