Skip to content

chore(deps): bump System.Text.Json from 8.0.2 to 8.0.4 in /src/PactNet.Abstractions #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 9, 2024

Bumps System.Text.Json from 8.0.2 to 8.0.4.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps System.Text.Json from 8.0.2 to 8.0.4.

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 9, 2024
@SymbioticKilla
Copy link

Hi @adamrodger,

can you please merge it and release a new version? It contains CVE fix. The security tools find as vulnerable transient dependency.

Thank you!

@adamrodger
Copy link
Contributor

Hi - if you're coming up against this CVE (e.g. security scans at work) and need to reference a new version to close down the alerts, the best way is to directly reference a newer version of the library in your project. We declare a minimum supported version, not a direct required version exactly.

.Net will happily let you use a higher version just fine, and this is also a testing library that shouldn't be shipped in your production code anyway.

@adamrodger
Copy link
Contributor

@dependabot close

@dependabot dependabot bot closed this Jul 23, 2024
@dependabot dependabot bot deleted the dependabot/nuget/src/PactNet.Abstractions/System.Text.Json-8.0.4 branch July 23, 2024 19:36
@SymbioticKilla
Copy link

SymbioticKilla commented Jul 24, 2024

@adamrodger
Thank you for quick answer!

It is correct what you say except the part with the minimum supported version. You declare direct dependency (version pin) and for the users it is transient. Transient dependencies should not be managed by them.

I know it is a test library, but the scanners in the companies scan whole repositories/package.lock.json files.

It would be nice if you can pin not vulnerable System.Text.Json or add net8.0 and pin nuget only for netstandard2.0.

Sorry to bother you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants