Skip to content

oxide_silo_idp_configuration: initial resource #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudomateo
Copy link
Collaborator

TODO

@sudomateo sudomateo linked an issue May 30, 2025 that may be closed by this pull request
@sudomateo
Copy link
Collaborator Author

To implement this resource the proper way (e.g., read using provider ID) the API change referenced in oxidecomputer/omicron#8240 is required, which would make Release 15 required for this change.

I'd like to ship this to be compatible with existing Oxide releases though so I'll update this resource to read using the provider name and silo ID and see if it works correctly.

@sudomateo sudomateo force-pushed the sudomateo/silo-idp-config branch from 3b66853 to 40ee907 Compare June 3, 2025 19:20
Copy link
Collaborator

@karencfv karencfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the work on this!

I'd like to ship this to be compatible with existing Oxide releases though so I'll update this resource to read using the provider name and silo ID and see if it works correctly.

I'm not super keen on doing this TBH 🤔 The issue with referencing names instead of IDs is that they are all designed to be mutable. Even if they are not mutable today, it is in the design docs that all names should have the ability to be mutable at some point.

We'll be releasing R15 soon, and all of our customer's racks are still updated by us. So I don't think there should be much of a problem waiting for this feature a few weeks more right?

If we add the functionality to reference names, it will be much more problematic to remove it in the future.

@sudomateo
Copy link
Collaborator Author

We'll be releasing R15 soon, and all of our customer's racks are still updated by us. So I don't think there should be much of a problem waiting for this feature a few weeks more right?

If we add the functionality to reference names, it will be much more problematic to remove it in the future.

I agree. I'll ask the customer who asked for this feature to see what their urgency and timelines are. I don't see why it can't wait for R15 especially since it'll be the better implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SAML IdP for silos
2 participants