[sp-sim] Simulate host flash hashing #8584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
commented
Jul 11, 2025
Comment on lines
+493
to
+497
| HostFlashHashState::HashStarted(started) => { | ||
| let started = *started; | ||
| self.finalize_host_flash_hash_if_sufficient_time_elapsed( | ||
| slot, started, | ||
| )?; |
There was a problem hiding this comment.
If we get a start_host_flash_hash() request while we're still hashing from a previous start request, this will return HfError::HashInProgress. I think the SP returns a generic HashError in this case, but maybe it should also return HashInProgress?
jgallagher
commented
Jul 11, 2025
| // hash of this slot. | ||
| if *component == SpComponent::HOST_CPU_BOOT_FLASH { | ||
| self.phase1_hash_state | ||
| .insert(*slot, HostFlashHashState::HashInvalidated); |
There was a problem hiding this comment.
I think this is consistent with the real SP, but wanted to check. If we start up and have this sequence of requests:
get_host_flash_hash-> will returnHfError::HashUncalculated- we do not get a request to
start_host_flash_hash - we perform an update, writing the target slot
- after the update, we get another
get_host_flash_hashrequest -> this will now returnHfError::RecalculateHash, because the act of writing sets our state toHashInvalidated
I think this is completely reasonable but wanted to double check it matches; any write will cause future gets to return HfError::RecalculateHash, even if we'd never calculated it a first time, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple spots here that I want to double-check are faithful to real SP behavior; will leave comments below.