[3/5] User data export: fix region snapshot replacement step saga #8557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For user data export, read-only volume copies are attached to a Pantry so that Nexus can read from them. The region snapshot replacement machinery needs to be taught about this new location of read-only volumes: this commit represents that fix. This PR is intentionally before the others in the set that actually create the user data export objects so that this saga is fixed before that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For user data export, read-only volume copies are attached to a Pantry so that Nexus can read from them. The region snapshot replacement machinery needs to be taught about this new location of read-only volumes: this commit represents that fix. This PR is intentionally before the others in the set that actually create the user data export objects so that this saga is fixed before that :)