-
Notifications
You must be signed in to change notification settings - Fork 45
Add desired host phase 2 contents to OmicronSledConfig
(PR 1/4)
#8538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
}; | ||
|
||
// TODO-john also test host phase 2 artifacts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and its friend below are both addressed in #8539
@@ -1944,6 +1946,9 @@ pub struct InvOmicronSledConfig { | |||
pub id: DbTypedUuid<OmicronSledConfigKind>, | |||
pub generation: Generation, | |||
pub remove_mupdate_override: Option<DbTypedUuid<MupdateOverrideKind>>, | |||
|
|||
#[diesel(embed)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
HostPhase2DesiredContents
is analogous toOmicronZoneImageSource
, but for OS images: either keep the current contents of the boot disk or set it to a specific artifact from the TUF repo depot. "Keep the current contents" should show up in three cases, just likeOmicronZoneImageSource::InstallDataset
: