[24/n] [reconfigurator-planning] support no-op image source updates #8486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
This was referenced Jul 1, 2025
sunshowers
changed the base branch from
sunshowers/spr/main.wip-22n-reconfigurator-planning-support-no-op-image-source-updates
to
main
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jul 3, 2025
| return None; | ||
| } | ||
|
|
||
| let file_name = format!("{}.tar.gz", artifact.id.name); |
There was a problem hiding this comment.
I don't think this name is consistent with real TUF repos, but maybe that doesn't matter? Kinda uneasy about the whole situation.
There was a problem hiding this comment.
yeah, definitely needs to be fixed.
There was a problem hiding this comment.
fixed by adding yet another mapping function...
Comment on lines
50
to
51
| "crucible-zone.tar.gz", | ||
| "crucible-pantry-zone.tar.gz", |
There was a problem hiding this comment.
Same as previous comment; some of these names are not consistent with real TUF repos.
There was a problem hiding this comment.
Addressed as part of #8518.
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/wip-22n-reconfigurator-planning-support-no-op-image-source-updates
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFD 556 discusses part of the mupdate recovery process being a zone image source switch from the install dataset to the TUF repo depot.
During discussions, we figured out that this doesn't have to be tied to the mupdate override stuff for the most part, and that this is a process we are allowed to perform on any zones where a mupdate override isn't in place.
This depends on some pending work in Sled Agent to treat image source switches as no-ops if the underlying hash is the same.
Depends on:
TODO: