[30/n] blueprint planner logic for mupdate overrides

dev-tools/reconfigurator-cli/src/lib.rs

@@ -210,6 +210,9 @@ fn process_command(
         Commands::SledShow(args) => cmd_sled_show(sim, args),
         Commands::SledSetPolicy(args) => cmd_sled_set_policy(sim, args),
         Commands::SledUpdateSp(args) => cmd_sled_update_sp(sim, args),
+        Commands::SledSetMupdateOverride(args) => {
+            cmd_sled_set_mupdate_override(sim, args)
+        }
         Commands::SiloList => cmd_silo_list(sim),
         Commands::SiloAdd(args) => cmd_silo_add(sim, args),
         Commands::SiloRemove(args) => cmd_silo_remove(sim, args),
@@ -265,6 +268,8 @@ enum Commands {
     SledSetPolicy(SledSetPolicyArgs),
     /// simulate updating the sled's SP versions
     SledUpdateSp(SledUpdateSpArgs),
+    /// simulate the sled's mupdate override field changing
+    SledSetMupdateOverride(SledSetMupdateOverrideArgs),
 
     /// list silos
     SiloList,
@@ -390,6 +395,15 @@ struct SledUpdateSpArgs {
     inactive: Option<ExpectedVersion>,
 }
 
+#[derive(Debug, Args)]
+struct SledSetMupdateOverrideArgs {
+    /// id of the sled
+    sled_id: SledUuid,
+
+    /// the new value of the mupdate override, or "unset"
+    mupdate_override_id: MupdateOverrideUuidOpt,
+}
+
 #[derive(Debug, Args)]
 struct SledRemoveArgs {
     /// id of the sled
@@ -993,6 +1007,32 @@ fn cmd_sled_update_sp(
     )))
 }
 
+fn cmd_sled_set_mupdate_override(
+    sim: &mut ReconfiguratorSim,
+    args: SledSetMupdateOverrideArgs,
+) -> anyhow::Result<Option<String>> {
+    let mut state = sim.current_state().to_mut();
+    state.system_mut().description_mut().sled_set_mupdate_override(
+        args.sled_id,
+        args.mupdate_override_id.into(),
+    )?;
+
+    let desc = match args.mupdate_override_id {
+        MupdateOverrideUuidOpt::Set(id) => format!("set to {id}"),
+        MupdateOverrideUuidOpt::Unset => "unset".to_owned(),
+    };
+
+    sim.commit_and_bump(
+        format!(
+            "reconfigurator-cli sled-set-mupdate-override: {}: {}",
+            args.sled_id, desc,
+        ),
+        state,
+    );
+
+    Ok(Some(format!("set sled {} mupdate override: {}", args.sled_id, desc)))
+}
+
 fn cmd_inventory_list(
     sim: &mut ReconfiguratorSim,
 ) -> anyhow::Result<Option<String>> {

dev-tools/reconfigurator-cli/tests/input/cmds-mupdate-update-flow.txt

@@ -0,0 +1,36 @@
+# Load an example system.
+
+load-example --nsleds 3 --ndisks-per-sled 1
+
+# Set one of the sled's zone's image sources to a specific artifact.
+blueprint-edit latest set-zone-image 466a9f29-62bf-4e63-924a-b9efdb86afec artifact 1.2.3 e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
+
+# Simulate a mupdate on sled 0 by setting the mupdate override field to a
+# new UUID (generated using uuidgen).
+sled-set-mupdate-override 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c 6123eac1-ec5b-42ba-b73f-9845105a9971
+
+# Generate a new inventory and plan against that.
+inventory-generate
+blueprint-plan latest eb0796d5-ab8a-4f7b-a884-b4aeacb8ab51
+
+# Diff the blueprints. This diff should show:
+#
+# * for sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c, "+ will remove mupdate override"
+# * for zone 466a9f29-62bf-4e63-924a-b9efdb86afec, a change from artifact to install-dataset
+blueprint-diff 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1 latest
+
+# Now simulate the new config being applied to the sled, which would
+# cause the mupdate override to be removed.
+sled-set-mupdate-override 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c unset
+
+# Generate a new inventory and plan against that.
+inventory-generate
+blueprint-plan latest 61f451b3-2121-4ed6-91c7-a550054f6c21
+
+# Diff the blueprints. This diff should show the "remove mupdate
+# override" line going away.
+# TODO: we do not yet reset the install dataset image back to
+# the desired artifact version -- we should do that in the future.
+blueprint-diff 58d5e830-0884-47d8-a7cd-b2b3751adeb4 latest
+
+# TODO: set target release

dev-tools/reconfigurator-cli/tests/output/cmds-set-remove-mupdate-override-stdout

@@ -488,7 +488,7 @@ parent:    afb09faf-a586-4483-9289-04d4f1d8ba23
  METADATA:
     created by:::::::::::::   reconfigurator-cli
     created at:::::::::::::   <REDACTED_TIMESTAMP>
-    comment::::::::::::::::   (none)
+    comment::::::::::::::::   updated target release minimum generation from 1 to 2
     internal DNS version:::   1
     external DNS version:::   1
     target release min gen:   2

nexus/reconfigurator/planning/Cargo.toml

@@ -13,6 +13,7 @@ chrono.workspace = true
 debug-ignore.workspace = true
 daft.workspace = true
 gateway-client.workspace = true
+iddqd.workspace = true
 id-map.workspace = true
 illumos-utils.workspace = true
 indexmap.workspace = true
@@ -36,6 +37,7 @@ slog-error-chain.workspace = true
 sp-sim.workspace = true
 static_assertions.workspace = true
 strum.workspace = true
+swrite.workspace = true
 thiserror.workspace = true
 tufaceous-artifact.workspace = true
 typed-rng.workspace = true