[th/black-reformat] style: adjust code so that different black versions format it the same #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatting that python black produces depends on the version of the tool. The authoritative version is the one from the github action, that is, "24.4.2" which we currently install via pip. On current Fedora 40, we have 22.12.0. It's cumbersome if different versions fight over the formatting. Even if the correct solution is to use the same version as used in github, we can avoid this problem by rewriting the code a bit, so that it formats the same with versions 22.12.0 and 24.4.2.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting that python black produces depends on the version of the tool. The authoritative version is the one from the github action, that is, "24.4.2" which we currently install via pip.
On current Fedora 40, we have 22.12.0.
It's cumbersome if different versions fight over the formatting. Even if the correct solution is to use the same version as used in github, we can avoid this problem by rewriting the code a bit, so that it formats the same with versions 22.12.0 and 24.4.2.