Sanitize node name before creating pod name #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom311
reviewed
May 22, 2025
m-naught
force-pushed
the
dotbug
branch
2 times, most recently
from
19ac3fe to
96ed4dd
Compare
thom311
reviewed
May 22, 2025
thom311
reviewed
May 22, 2025
m-naught
force-pushed
the
dotbug
branch
6 times, most recently
from
4f59537 to
0016adc
Compare
thom311
reviewed
May 22, 2025
Some nodes may be named after a hostname with dots. We use the node name to generate podnames, but dots are invalid in pod names and must be sanitised. Signed-off-by: Mark Naughton <mnaughto@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pods can't contain dots, replace them with dashes if the node name has them.