Update Client.cs #66
Merged
Update Client.cs #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some route (eg /cloud/project/{serviceName}/kube/{kubeId}/nodepool/{nodePoolId}) returns status code 204.
Currently, this creates a null exception, as it isn't HttpStatusCode.OK and there isn't an Exception to extract.
|
Thanks for your contribution @f-lalonde, Could you also add a test related to this change ? Thanks ! |
Done! Let me know if there's anything else that's required. |
amstuta
previously approved these changes
Feb 19, 2025
|
I missed it but you should sign your commit and after that we'll be able to merge ! |
f-lalonde
force-pushed
the
patch-1
branch
3 times, most recently
from
1d10714 to
bbe0a20
Compare
|
Sorry for all the force push, it's the first time I have to sign a commit / amend a commit with a signature. Everything should be in order now 🤞 |
Signed-off-by: Francis Lalonde <xargath@hotmail.com>
amstuta
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some routes (at the very least :
/cloud/project/{serviceName}/kube/{kubeId}/nodepool/{nodePoolId}) returns the http status code 204.Currently, this creates a null exception, as it isn't HttpStatusCode.OK and there isn't an Exception to extract.
Fixes : #63