Results of checks are now collected before handling #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple checks were handled only the output of the last check remained. This is because all checks were individually handled and each handling cleared the output. We now collect the check result including the exceptions and then send it for handling. We also now only print a summary of the results in the CheckRegistry as the output was too extensive.
agoscinski
force-pushed
the
split-checks-result
branch
from
b3c842d to
e43d5ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple checks were handled only the output of the last check remained. This is because all checks were individually handled and each handling cleared the output. We now collect the check result including the exceptions and then send it for handling.
📚 Documentation preview 📚: https://scicode-widgets--64.org.readthedocs.build/en/64/