Skip to content

Conversation

scpeters
Copy link
Member

Related to gazebosim/gz-sim#2849.

Test standalone executable.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@j-rivero
Copy link
Collaborator

j-rivero commented May 7, 2025

Is there anyway that we can try this PR with gazebosim/gz-sim#2849 before merging?

@scpeters
Copy link
Member Author

scpeters commented May 7, 2025

Is there anyway that we can try this PR with gazebosim/gz-sim#2849 before merging?

this fix will only apply to the gz-sim10 bottles. We can test it by creating mathcing ci_matching_branch/standalone_execs branches from this and one in release-tools and running https://build.osrfoundation.org/job/gz_sim10-install_bottle-homebrew-amd64/ with the specified release-tools branch

if the rpath is still a problem when building from source, I think we would need to address that in the gz-sim pull request or configuring additional cmake arguments

@scpeters
Copy link
Member Author

scpeters commented May 7, 2025

Is there anyway that we can try this PR with gazebosim/gz-sim#2849 before merging?

this fix will only apply to the gz-sim10 bottles. We can test it by creating mathcing ci_matching_branch/standalone_execs branches from this and one in release-tools and running https://build.osrfoundation.org/job/gz_sim10-install_bottle-homebrew-amd64/ with the specified release-tools branch

created the branches and started a build:

Build Status https://build.osrfoundation.org/job/gz_sim10-install_bottle-homebrew-amd64/188/

@scpeters
Copy link
Member Author

scpeters commented May 8, 2025

created the branches and started a build:

Build Status https://build.osrfoundation.org/job/gz_sim10-install_bottle-homebrew-amd64/188/

I forgot to update the target branch

done in bd09496 and retriggering

Build Status https://build.osrfoundation.org/job/gz_sim10-install_bottle-homebrew-amd64/189/

@scpeters scpeters marked this pull request as ready for review May 15, 2025 05:32
@scpeters
Copy link
Member Author

since gazebosim/gz-sim#2849 has merged, I'll merge this now

@scpeters scpeters merged commit c772d08 into master May 15, 2025
1 check passed
@scpeters scpeters deleted the scpeters/standalone_execs branch May 15, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants