Return first IP in network with NetworksWithin #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when looking up a network that is more specific than the network in the database using NetworksWithin. Previously, the network number would be set to the network number of the provided *net.IPNet. This changes it to the canonical form.
horgh
approved these changes
Jun 28, 2024
traverse_test.go
Outdated
| @@ -71,20 +73,50 @@ var tests = []networkTest{ | |||
| }, | |||
| }, | |||
| { | |||
| // This is intentially in non-canonical form to test | |||
There was a problem hiding this comment.
Thanks! I force pushed with that fixed.
oschwald
force-pushed
the
greg/fix-networks-within
branch
from
9c77193 to
b2df6c3
Compare
horgh
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the network being looked up was more specific than the network
in the database, the network number would be set to the network number of the
network being looked up rather than it being placed in canonical form.