Adding 'About' option under 'Help' menu #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 68.78% 68.78%
=======================================
Files 110 110
Lines 9035 9035
Branches 402 402
=======================================
Hits 6215 6215
Misses 2820 2820 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
shivaahir158
changed the title
main.js
Outdated
| const packagePath = path.join(__dirname, 'package.json'); | ||
| const packageData = JSON.parse(fs.readFileSync(packagePath, 'utf8')); | ||
|
|
||
| const message = `${packageData.build.productName}\nVersion: ${packageData.version}\nAuthor: ${packageData.author}\nCopyright: ${packageData.build.copyright}\nType: Engineering`; |
There was a problem hiding this comment.
Type is still hardcoded here, please remove it.
Also confirm that production build has same data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for 'About' under 'Help' menu, as discussed.