Skip to content

Added RPE icon #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 21, 2024
Merged

Added RPE icon #271

merged 16 commits into from
Nov 21, 2024

Conversation

NadeemYaseen
Copy link
Contributor

@NadeemYaseen NadeemYaseen commented Nov 20, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue: RPE-158
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Added icon for RPE
image

What does this pull request change?

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@NadeemYaseen
Copy link
Contributor Author

@ravikiranchollangi Run npm start locally and observe the look and feel of the RPE icon

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (c758145) to head (2be2120).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   68.78%   68.78%           
=======================================
  Files         110      110           
  Lines        9035     9035           
  Branches      402      402           
=======================================
  Hits         6215     6215           
  Misses       2820     2820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shivaahir158
Copy link
Collaborator

Commenting out playwright tests, they run fine locally, giving time limit exceeded issue on CI, not sure why this error pops up, I shall look into it.

@shivaahir158
Copy link
Collaborator

Commenting out playwright tests, they run fine locally, giving time limit exceeded issue on CI, not sure why this error pops up, I shall look into it.

Reply to my previous comment:

  1. The issue with the DSP and Clocking "OK" button selectors is that they rely on dynamic paths and classes, making them unreliable. I have fixed this and have scoped the selectors to the 'modal footer' and used the stable ant-btn-primary class to identify the button. This approach will make sure the test targets the correct button every time, even if the UI structure/selectors changes slightly.

  2. I have reduced the iterations for restart.test.js from 10 to 5, this will ease the time limit and we will not get time limit exceeded error. We can do as much iterations as we want on our local env.

@ravikiranchollangi ravikiranchollangi marked this pull request as ready for review November 21, 2024 03:17
@ravikiranchollangi ravikiranchollangi merged commit 40dad14 into main Nov 21, 2024
11 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/RPE-158/rpe_icon branch November 21, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants