Skip to content

Running playwright tests on CI #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

shivaahir158
Copy link
Collaborator

@shivaahir158 shivaahir158 commented Nov 15, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details -

Draft PR to test the e2e runs on the CI, the tests run fine on the local env, shall investigate the CI issue first and will raise the final PR.

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests: tests/e2e
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (f5dd78a) to head (446c1e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         110      110           
  Lines        9022     9022           
  Branches      402      402           
=======================================
  Hits         6210     6210           
  Misses       2812     2812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shivaahir158
Copy link
Collaborator Author

@NadeemYaseen , the e2e tests run in local env all the time, not sure why they have time limit exceeded error on the CI, just FYI.

On local there is currently no way to test e2e tests from latest pull because of no device availability, I am using old fetches where device.xml existed. Selectors are working fine so no issues there.

@ravikiranchollangi
Copy link
Contributor

@NadeemYaseen , the e2e tests run in local env all the time, not sure why they have time limit exceeded error on the CI, just FYI.

On local there is currently no way to test e2e tests from latest pull because of no device availability, I am using old fetches where device.xml existed. Selectors are working fine so no issues there.

@shivaahir158 didn't we agree on manually copying the devices folder ? Why can't we do that to run local e2e tests ?

@shivaahir158 shivaahir158 deleted the playwright-run-on-CI branch November 18, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants