Add support for overloads, extending name paths with overload indices #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows) Quoting of arguments containing spaces is now handled centrally Fixes #735
Adapt SolidLanguageServer.request_document_symbols to fill overload_idx Introduce symbol cache versioning within the saved file, avoiding storage of old cache files.
…Method(int) <T>' to just 'myMethod' handling overloads via SolidLSP's newly introduced overload_idx instead Fixes #578
…efficency Implements #515
opcode81
changed the title
…hile issuing documentSymbols request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for overloaded symbols by
overload_idx(0-based), which is added to the end of the name path (e.g.MyClass/myOverloadedMethod[1])SolidLanguageServer.request_document_symbols) accordinglyNamePathMatcherfor efficiency)Fixes #735
Implements #515
Fixes #578