[GR-18163] Fix #cloneUninitialized() for assignable nodes

PullRequest: truffleruby/4291

Author: andrykonchin

spec/truffle/cloning_uninitialized_spec.rb

@@ -0,0 +1,71 @@
+# Copyright (c) 2024 Oracle and/or its affiliates. All rights reserved. This
+# code is released under a tri EPL/GPL/LGPL license. You can use it,
+# redistribute it and/or modify it under the terms of the:
+#
+# Eclipse Public License version 2.0, or
+# GNU General Public License version 2, or
+# GNU Lesser General Public License version 2.1.
+
+require_relative '../ruby/spec_helper'
+
+describe "RubyNode#cloneUninitialized() for nodes implementing AssignableNode interface" do
+  # The Module#define_method with block argument triggers cloning of the proc and converting it into a lambda
+  it "works for local variable assignment" do
+    Module.new.define_method("foo") do
+    rescue => e # rubocop:disable Lint/SuppressedException, Lint/UselessAssignment
+    end
+
+    1.should == 1
+  end
+
+  it "works for local variable assignment when it is already declared in an outer scope" do
+    e = nil
+    Module.new.define_method("foo") do
+    rescue => e # rubocop:disable Lint/SuppressedException
+    end
+
+    e.should == nil
+  end
+
+  it "works for instance variable assignment" do
+    Module.new.define_method("foo") do
+    rescue => @e # rubocop:disable Lint/SuppressedException
+    end
+
+    1.should == 1
+  end
+
+  it "works for class variable assignment" do
+    Module.new.define_method("foo") do
+    rescue => @@e # rubocop:disable Lint/SuppressedException
+    end
+
+    1.should == 1
+  end
+
+  it "works for global variable assignment" do
+    Module.new.define_method("foo") do
+    rescue => $clonning_uninitialized_spec # rubocop:disable Lint/SuppressedException
+    end
+
+    $clonning_uninitialized_spec.should == nil
+  end
+
+  it "works for a constant assignment" do
+    m = Module.new
+    m.define_method("foo") do
+    rescue => m::E # rubocop:disable Lint/SuppressedException
+    end
+
+    1.should == 1
+  end
+
+  it "works for a multi-assignment" do
+    a = nil
+    Module.new.define_method("foo") do
+      a, b, c = [] # rubocop:disable Lint/UselessAssignment
+    end
+
+    a.should == nil
+  end
+end

spec/truffle/parsing/fixtures/rescue/capturing/with_local_variable.yaml

@@ -72,14 +72,6 @@ ast: |
                                                           frameSlot = 2 # error
                                                           sourceCharIndex = 37
                                                           sourceLength = 5
-                                                      children:
-                                                          valueNode =
-                                                              DeadNode
-                                                                  attributes:
-                                                                      flags = 0
-                                                                      reason = "YARPTranslator#visitLocalVariableTargetNode"
-                                                                      sourceCharIndex = -1
-                                                                      sourceLength = 0
                                       IntegerFixnumLiteralNode
                                           attributes:
                                               flags = 1

spec/truffle/parsing/fixtures/rescue/with_exception_and_variable.yaml

@@ -75,14 +75,6 @@ ast: |
                                                           frameSlot = 2 # error
                                                           sourceCharIndex = 37
                                                           sourceLength = 5
-                                                      children:
-                                                          valueNode =
-                                                              DeadNode
-                                                                  attributes:
-                                                                      flags = 0
-                                                                      reason = "YARPTranslator#visitLocalVariableTargetNode"
-                                                                      sourceCharIndex = -1
-                                                                      sourceLength = 0
                                       IntegerFixnumLiteralNode
                                           attributes:
                                               flags = 1

spec/truffle/parsing/fixtures/rescue/without_exception_but_with_variable.yaml

@@ -46,14 +46,6 @@ ast: |
                                                           frameSlot = 2 # error
                                                           sourceCharIndex = 24
                                                           sourceLength = 5
-                                                      children:
-                                                          valueNode =
-                                                              DeadNode
-                                                                  attributes:
-                                                                      flags = 0
-                                                                      reason = "YARPTranslator#visitLocalVariableTargetNode"
-                                                                      sourceCharIndex = -1
-                                                                      sourceLength = 0
                                       IntegerFixnumLiteralNode
                                           attributes:
                                               flags = 1

src/main/java/org/truffleruby/language/constants/WriteConstantNode.java

@@ -112,7 +112,7 @@ public RubyNode cloneUninitialized() {
         var copy = new WriteConstantNode(
                 name,
                 moduleNode.cloneUninitialized(),
-                valueNode.cloneUninitialized());
+                cloneUninitialized(valueNode));
         return copy.copyFlags(this);
     }
 

src/main/java/org/truffleruby/language/locals/WriteLocalVariableNode.java

@@ -65,7 +65,7 @@ public String toString() {
     public RubyNode cloneUninitialized() {
         var copy = new WriteLocalVariableNode(
                 frameSlot,
-                valueNode.cloneUninitialized());
+                cloneUninitialized(valueNode));
         return copy.copyFlags(this);
     }
 

src/main/java/org/truffleruby/language/objects/classvariables/WriteClassVariableNode.java

@@ -79,7 +79,7 @@ public RubyNode cloneUninitialized() {
         var copy = new WriteClassVariableNode(
                 lexicalScopeNode.cloneUninitialized(),
                 name,
-                rhs.cloneUninitialized());
+                cloneUninitialized(rhs));
         return copy.copyFlags(this);
     }
 

src/main/java/org/truffleruby/parser/YARPMultiTargetNodeTranslator.java

@@ -229,8 +229,7 @@ public AssignableNode visitSplatNode(Nodes.SplatNode node) {
     public AssignableNode visitRequiredParameterNode(Nodes.RequiredParameterNode node) {
         final String name = node.name;
         final ReadLocalNode lhs = yarpTranslator.getEnvironment().findLocalVarNode(name);
-        final RubyNode rhs = new DeadNode("YARPMultiTargetNodeTranslator#visitRequiredParameterNode");
-        final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
+        final WriteLocalNode rubyNode = lhs.makeWriteNode(null);
 
         return rubyNode.toAssignableNode();
     }

src/main/java/org/truffleruby/parser/YARPTranslator.java

@@ -2654,8 +2654,7 @@ public WriteLocalNode visitLocalVariableWriteNode(Nodes.LocalVariableWriteNode n
     public WriteLocalNode visitLocalVariableTargetNode(Nodes.LocalVariableTargetNode node) {
         final String name = node.name;
         final ReadLocalNode lhs = environment.findLocalVarNode(name);
-        final RubyNode rhs = new DeadNode("YARPTranslator#visitLocalVariableTargetNode");
-        final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
+        final WriteLocalNode rubyNode = lhs.makeWriteNode(null);
 
         assignPositionAndFlags(node, rubyNode);
         return rubyNode;