Skip to content

Commit 3eb8220

Browse files
committed
Replace DeadNode with null for stub values of local variables assignings
1 parent 564cbf5 commit 3eb8220

File tree

5 files changed

+2
-28
lines changed

5 files changed

+2
-28
lines changed

spec/truffle/parsing/fixtures/rescue/capturing/with_local_variable.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,6 @@ ast: |
7272
frameSlot = 2 # error
7373
sourceCharIndex = 37
7474
sourceLength = 5
75-
children:
76-
valueNode =
77-
DeadNode
78-
attributes:
79-
flags = 0
80-
reason = "YARPTranslator#visitLocalVariableTargetNode"
81-
sourceCharIndex = -1
82-
sourceLength = 0
8375
IntegerFixnumLiteralNode
8476
attributes:
8577
flags = 1

spec/truffle/parsing/fixtures/rescue/with_exception_and_variable.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,6 @@ ast: |
7575
frameSlot = 2 # error
7676
sourceCharIndex = 37
7777
sourceLength = 5
78-
children:
79-
valueNode =
80-
DeadNode
81-
attributes:
82-
flags = 0
83-
reason = "YARPTranslator#visitLocalVariableTargetNode"
84-
sourceCharIndex = -1
85-
sourceLength = 0
8678
IntegerFixnumLiteralNode
8779
attributes:
8880
flags = 1

spec/truffle/parsing/fixtures/rescue/without_exception_but_with_variable.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@ ast: |
4646
frameSlot = 2 # error
4747
sourceCharIndex = 24
4848
sourceLength = 5
49-
children:
50-
valueNode =
51-
DeadNode
52-
attributes:
53-
flags = 0
54-
reason = "YARPTranslator#visitLocalVariableTargetNode"
55-
sourceCharIndex = -1
56-
sourceLength = 0
5749
IntegerFixnumLiteralNode
5850
attributes:
5951
flags = 1

src/main/java/org/truffleruby/parser/YARPMultiTargetNodeTranslator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,7 @@ public AssignableNode visitSplatNode(Nodes.SplatNode node) {
229229
public AssignableNode visitRequiredParameterNode(Nodes.RequiredParameterNode node) {
230230
final String name = node.name;
231231
final ReadLocalNode lhs = yarpTranslator.getEnvironment().findLocalVarNode(name);
232-
final RubyNode rhs = new DeadNode("YARPMultiTargetNodeTranslator#visitRequiredParameterNode");
233-
final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
232+
final WriteLocalNode rubyNode = lhs.makeWriteNode(null);
234233

235234
return rubyNode.toAssignableNode();
236235
}

src/main/java/org/truffleruby/parser/YARPTranslator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2654,8 +2654,7 @@ public WriteLocalNode visitLocalVariableWriteNode(Nodes.LocalVariableWriteNode n
26542654
public WriteLocalNode visitLocalVariableTargetNode(Nodes.LocalVariableTargetNode node) {
26552655
final String name = node.name;
26562656
final ReadLocalNode lhs = environment.findLocalVarNode(name);
2657-
final RubyNode rhs = new DeadNode("YARPTranslator#visitLocalVariableTargetNode");
2658-
final WriteLocalNode rubyNode = lhs.makeWriteNode(rhs);
2657+
final WriteLocalNode rubyNode = lhs.makeWriteNode(null);
26592658

26602659
assignPositionAndFlags(node, rubyNode);
26612660
return rubyNode;

0 commit comments

Comments
 (0)