Fix missing glob entries dot subdirectories when using **/* with FNM_DOTMATCH

Author: bjfish

spec/ruby/core/dir/fixtures/common.rb

@@ -36,6 +36,8 @@ def self.mock_dir_files
         .dotfile
         .dotsubdir/.dotfile
         .dotsubdir/nondotfile
+        nested/.dotsubir/.dotfile
+        nested/.dotsubir/nondotfile
 
         deeply/.dotfile
         deeply/nested/.dotfile.ext
@@ -160,6 +162,7 @@ def self.expected_paths
       dir_filename_ordering
       file_one.ext
       file_two.ext
+      nested
       nondotfile
       special
       subdir_one

spec/ruby/core/dir/glob_spec.rb

@@ -59,6 +59,8 @@
       deeply/nested/directory/
       deeply/nested/directory/structure/
       dir/
+      nested/
+      nested/.dotsubir/
       special/
       special/test{1}/
       subdir_one/
@@ -68,6 +70,18 @@
     Dir.glob('**/', File::FNM_DOTMATCH).sort.should == expected
   end
 
+  it "recursively matches files and directories in nested dot subdirectory with 'nested/**/*' from the current directory and option File::FNM_DOTMATCH" do
+    expected = %w[
+      nested/.
+      nested/.dotsubir
+      nested/.dotsubir/.
+      nested/.dotsubir/.dotfile
+      nested/.dotsubir/nondotfile
+    ]
+
+    Dir.glob('nested/**/*', File::FNM_DOTMATCH).sort.should == expected.sort
+  end
+
   # This is a separate case to check **/ coming after a constant
   # directory as well.
   it "recursively matches any subdirectories except './' or '../' with '**/' and option File::FNM_DOTMATCH" do
@@ -80,6 +94,8 @@
       ./deeply/nested/directory/
       ./deeply/nested/directory/structure/
       ./dir/
+      ./nested/
+      ./nested/.dotsubir/
       ./special/
       ./special/test{1}/
       ./subdir_one/

spec/ruby/core/dir/shared/glob.rb

@@ -53,6 +53,7 @@
       dir_filename_ordering
       file_one.ext
       file_two.ext
+      nested
       nondotfile
       special
       subdir_one
@@ -156,6 +157,7 @@
       dir_filename_ordering
       file_one.ext
       file_two.ext
+      nested
       nondotfile
       special
       subdir_one
@@ -177,6 +179,7 @@
       deeply/nested/directory/
       deeply/nested/directory/structure/
       dir/
+      nested/
       special/
       special/test{1}/
       subdir_one/

spec/tags/core/dir/glob_tags.txt

@@ -0,0 +1 @@
+fails:Dir.glob recursively matches files and directories in nested dot subdirectory with 'nested/**/*' from the current directory and option File::FNM_DOTMATCH

src/main/ruby/truffleruby/core/dir_glob.rb

@@ -163,7 +163,7 @@ def call(matches, start, glob_base_dir)
             full = path_join(path, ent)
             mode = Truffle::POSIX.truffleposix_lstat_mode(path_join(glob_base_dir, full))
 
-            if Truffle::StatOperations.directory?(mode) and ent.getbyte(0) != 46  # ?.
+            if Truffle::StatOperations.directory?(mode) and (allow_dots or ent.getbyte(0) != 46) # ?.
               stack << full
               @next.call matches, full, glob_base_dir
             end