[GR-18163] Raise ArgumentError for nul-separated strings in Dir.{glob,[]}

PullRequest: truffleruby/2196

Author: eregon

CHANGELOG.md

@@ -26,6 +26,7 @@ Compatibility:
 * Implemented `FrozenError#receiver`.
 * `Proc#<<` and `Proc#>>` raises TypeError if passed not callable object (#2004, @ssnickolay).
 * Support time and date related messages for `Time` (#2166).
+* Updated `Dir.{glob,[]}` to raise `ArgumentError` for nul-separated strings.
 
 Performance:
 

spec/tags/core/dir/element_reference_tags.txt

@@ -227,7 +227,8 @@ def [](*patterns, base: nil)
       if patterns.size == 1
         pattern = Truffle::Type.coerce_to_path(patterns[0], false)
         return [] if pattern.empty?
-        patterns = glob_split pattern
+        raise ArgumentError, 'nul-separated glob pattern is deprecated' if pattern.include? "\0"
+        patterns = [pattern]
       end
 
       glob patterns, base: base
@@ -240,8 +241,8 @@ def glob(pattern, flags=0, base: nil, &block)
         pattern = Truffle::Type.coerce_to_path(pattern, false)
 
         return [] if pattern.empty?
-
-        patterns = glob_split pattern
+        raise ArgumentError, 'nul-separated glob pattern is deprecated' if pattern.include? "\0"
+        patterns = [pattern]
       end
 
       matches = []
@@ -274,16 +275,6 @@ def glob(pattern, flags=0, base: nil, &block)
       end
     end
 
-    def glob_split(pattern)
-      result = []
-      start = 0
-      while idx = Primitive.find_string(pattern, "\0", start)
-        result << pattern.byteslice(start, idx)
-        start = idx + 1
-      end
-      result << pattern.byteslice(start, pattern.bytesize)
-    end
-
     def foreach(path)
       return to_enum(:foreach, path) unless block_given?