Address this-escape warning in RubyRootNode

eregon · eregon · commit 95363fe593d0 · 2023-07-06T14:51:09.000+02:00
diff --git a/src/main/java/org/truffleruby/language/RubyRootNode.java b/src/main/java/org/truffleruby/language/RubyRootNode.java
@@ -62,14 +62,14 @@ public RubyRootNode(
 
         // Ensure the body node is instrument-able, which requires a non-null SourceSection
         if (!body.hasSource()) {
-            body.unsafeSetSourceSection(getSourceSection());
+            body.unsafeSetSourceSection(sourceSection);
         }
 
         body.unsafeSetIsCall();
         body.unsafeSetIsRoot();
 
         if (language.options.CHECK_CLONE_UNINITIALIZED_CORRECTNESS) {
-            this.bodyCopy = copyBody();
+            this.bodyCopy = NodeUtil.cloneNode(body);
         } else {
             this.bodyCopy = null;
         }

Original file line number	Diff line number	Diff line change
`@@ -62,14 +62,14 @@ public RubyRootNode(`
`62`	`62`
`63`	`63`	`// Ensure the body node is instrument-able, which requires a non-null SourceSection`
`64`	`64`	`if (!body.hasSource()) {`
`65`		`- body.unsafeSetSourceSection(getSourceSection());`
	`65`	`+ body.unsafeSetSourceSection(sourceSection);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`body.unsafeSetIsCall();`
`69`	`69`	`body.unsafeSetIsRoot();`
`70`	`70`
`71`	`71`	`if (language.options.CHECK_CLONE_UNINITIALIZED_CORRECTNESS) {`
`72`		`- this.bodyCopy = copyBody();`
	`72`	`+ this.bodyCopy = NodeUtil.cloneNode(body);`
`73`	`73`	`} else {`
`74`	`74`	`this.bodyCopy = null;`
`75`	`75`	`}`