ListParseNode this-escape is hard to avoid and is fine

* sourceCharIndex/sourceLength are set before addInternal() is called,
  which calls extendPosition() and use those fields.

Author: eregon

src/main/java/org/truffleruby/parser/ast/ListParseNode.java

@@ -48,6 +48,7 @@ public abstract class ListParseNode extends ParseNode {
      *
      * @param position where list is
      * @param firstNode first element of the list */
+    @SuppressWarnings("this-escape")
     protected ListParseNode(SourceIndexLength position, ParseNode firstNode) {
         super(position);
 
@@ -66,7 +67,7 @@ public NodeType getNodeType() {
         return NodeType.LISTNODE;
     }
 
-    protected void growList(int mustBeDelta) {
+    private void growList(int mustBeDelta) {
         int newSize = list.length * 2;
         // Fairly arbitrary to scale 1.5 here but this means we are adding a lot so I think
         // we can taper the multiplier
@@ -79,7 +80,7 @@ protected void growList(int mustBeDelta) {
         list = newList;
     }
 
-    protected void addInternal(ParseNode node) {
+    private void addInternal(ParseNode node) {
         if (size >= list.length) {
             growList(1);
         }

src/main/java/org/truffleruby/parser/ast/ParseNode.java

@@ -62,11 +62,11 @@ public ParseNode(SourceIndexLength position) {
                 this instanceof RequiredKeywordArgumentValueParseNode : this.getClass();
     }
 
-    public void setNewline() {
+    public final void setNewline() {
         this.newline = true;
     }
 
-    public boolean isNewline() {
+    public final boolean isNewline() {
         return newline;
     }
 
@@ -79,7 +79,7 @@ public final SourceIndexLength getPosition() {
         return new SourceIndexLength(sourceCharIndex, sourceLength);
     }
 
-    public void extendPosition(ParseNode node) {
+    public final void extendPosition(ParseNode node) {
         if (this.hasPosition() && node.hasPosition()) {
             int begin = Math.min(this.sourceCharIndex, node.sourceCharIndex);
             int end = Math.max(this.sourceCharIndex + this.sourceLength, node.sourceCharIndex + node.sourceLength);
@@ -88,7 +88,7 @@ public void extendPosition(ParseNode node) {
         }
     }
 
-    public void extendPosition(SourceIndexLength pos) {
+    public final void extendPosition(SourceIndexLength pos) {
         if (this.hasPosition() && pos.isAvailable()) {
             int begin = Math.min(this.sourceCharIndex, pos.getCharIndex());
             int end = Math.max(this.sourceCharIndex + this.sourceLength, pos.getCharEnd());