[GR-45370] JDK 21 is LTS, remove JDK 17

PullRequest: truffleruby/3895

Author: eregon

ci.jsonnet

@@ -12,6 +12,7 @@
 import pipes
 from os.path import join, exists, basename
 import shutil
+import sys
 
 import mx
 import mx_gate
@@ -227,7 +228,7 @@ def ruby_spotbugs(args):
     spotbugsArgs = ['-textui', '-low', '-longBugCodes', '-include', filters]
     if mx.is_interactive():
         spotbugsArgs.append('-progress')
-    mx_spotbugs.spotbugs(args, spotbugsArgs)
+    sys.exit(mx_spotbugs.spotbugs(args, spotbugsArgs))
 
 def verify_ci(args):
     """Verify CI configuration"""

mx.truffleruby/mx_truffleruby.py

@@ -24,6 +24,8 @@
         <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN" />
         <Bug pattern="BX_UNBOXING_IMMEDIATELY_REBOXED" /> <!-- used as a way to assert the type -->
         <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS" />
+        <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
+        <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ" />
       </Or>
     </Not>
   </Match>

mx.truffleruby/spotbugs-filters.xml

@@ -11,6 +11,7 @@
 
 import java.io.PrintStream;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -195,7 +196,7 @@ protected boolean runLauncherAction() {
                         .redirectOutput(Redirect.INHERIT) // set the output of the pager to the terminal and not a pipe
                         .redirectError(Redirect.INHERIT) // set the error of the pager to the terminal and not a pipe
                         .start();
-                PrintStream out = new PrintStream(process.getOutputStream());
+                PrintStream out = new PrintStream(process.getOutputStream(), false, StandardCharsets.UTF_8);
 
                 setOutput(out);
                 boolean code = super.runLauncherAction();

src/launcher/java/org/truffleruby/launcher/RubyLauncher.java

@@ -97,7 +97,7 @@
 import com.oracle.truffle.api.source.Source;
 import sun.misc.SignalHandler;
 
-public class RubyContext {
+public final class RubyContext {
 
     private final RubyLanguage language;
     @CompilationFinal private TruffleLanguage.Env env;
@@ -528,7 +528,7 @@ private void dispose() {
             RubyLanguage.LOGGER.info(
                     "Total VALUE object to native conversions: " + getValueWrapperManager().totalHandleAllocations());
         }
-        valueWrapperManager.freeAllBlocksInMap(language);
+        valueWrapperManager.freeAllBlocksInMap();
     }
 
     public boolean isPreInitializing() {

src/main/java/org/truffleruby/RubyContext.java

@@ -25,7 +25,7 @@
 
 import com.oracle.truffle.api.TruffleFile;
 
-public class RubyFileTypeDetector implements TruffleFile.FileTypeDetector {
+public final class RubyFileTypeDetector implements TruffleFile.FileTypeDetector {
 
     private static final String[] KNOWN_RUBY_FILES = new String[]{ "Gemfile", "Rakefile" };
     private static final String[] KNOWN_RUBY_SUFFIXES = new String[]{ ".rb", ".rake", ".gemspec" };

src/main/java/org/truffleruby/RubyFileTypeDetector.java

@@ -256,7 +256,7 @@ private RubyThread getOrCreateForeignThread(RubyContext context, Thread thread)
     public Thread cleanerThread = null;
     @CompilationFinal public Cleaner cleaner = null;
 
-    public volatile ValueWrapperManager.HandleBlockWeakReference[] handleBlockSharedMap = new ValueWrapperManager.HandleBlockWeakReference[0];
+    @SuppressFBWarnings("VO_VOLATILE_REFERENCE_TO_ARRAY") public volatile ValueWrapperManager.HandleBlockWeakReference[] handleBlockSharedMap = new ValueWrapperManager.HandleBlockWeakReference[0];
     public final ValueWrapperManager.HandleBlockAllocator handleBlockAllocator = new ValueWrapperManager.HandleBlockAllocator();
 
     @CompilationFinal public LanguageOptions options;

src/main/java/org/truffleruby/RubyLanguage.java

@@ -26,7 +26,7 @@
  ***** END LICENSE BLOCK *****/
 package org.truffleruby.algorithms;
 
-public class Randomizer {
+public final class Randomizer {
 
     private static final int N = 624;
     private static final int M = 397;

src/main/java/org/truffleruby/algorithms/Randomizer.java

@@ -28,7 +28,7 @@
 
 import com.oracle.truffle.api.TruffleOptions;
 
-public class ParserCache {
+public final class ParserCache {
 
     public static final Map<String, RootParseNode> INSTANCE;
 

src/main/java/org/truffleruby/aot/ParserCache.java

@@ -54,7 +54,7 @@
 import com.oracle.truffle.api.TruffleOptions;
 import com.oracle.truffle.api.dsl.NodeFactory;
 
-public class CoreMethodNodeManager {
+public final class CoreMethodNodeManager {
 
     private final RubyContext context;
     private final RubyLanguage language;
@@ -509,7 +509,7 @@ public static NodeFactory<? extends RubyBaseNode> loadNodeFactory(String nodeFac
         return (NodeFactory<? extends RubyBaseNode>) instance;
     }
 
-    public static class MethodDetails {
+    public static final class MethodDetails {
 
         private final String moduleName;
         private final CoreMethod methodAnnotation;