Address SpotBugs warnings

Author: eregon

mx.truffleruby/spotbugs-filters.xml

@@ -24,6 +24,8 @@
         <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN" />
         <Bug pattern="BX_UNBOXING_IMMEDIATELY_REBOXED" /> <!-- used as a way to assert the type -->
         <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS" />
+        <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
+        <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ" />
       </Or>
     </Not>
   </Match>

src/launcher/java/org/truffleruby/launcher/RubyLauncher.java

@@ -11,6 +11,7 @@
 
 import java.io.PrintStream;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -195,7 +196,7 @@ protected boolean runLauncherAction() {
                         .redirectOutput(Redirect.INHERIT) // set the output of the pager to the terminal and not a pipe
                         .redirectError(Redirect.INHERIT) // set the error of the pager to the terminal and not a pipe
                         .start();
-                PrintStream out = new PrintStream(process.getOutputStream());
+                PrintStream out = new PrintStream(process.getOutputStream(), false, StandardCharsets.UTF_8);
 
                 setOutput(out);
                 boolean code = super.runLauncherAction();

src/main/java/org/truffleruby/RubyContext.java

@@ -528,7 +528,7 @@ private void dispose() {
             RubyLanguage.LOGGER.info(
                     "Total VALUE object to native conversions: " + getValueWrapperManager().totalHandleAllocations());
         }
-        valueWrapperManager.freeAllBlocksInMap(language);
+        valueWrapperManager.freeAllBlocksInMap();
     }
 
     public boolean isPreInitializing() {

src/main/java/org/truffleruby/RubyLanguage.java

@@ -256,7 +256,7 @@ private RubyThread getOrCreateForeignThread(RubyContext context, Thread thread)
     public Thread cleanerThread = null;
     @CompilationFinal public Cleaner cleaner = null;
 
-    public volatile ValueWrapperManager.HandleBlockWeakReference[] handleBlockSharedMap = new ValueWrapperManager.HandleBlockWeakReference[0];
+    @SuppressFBWarnings("VO_VOLATILE_REFERENCE_TO_ARRAY") public volatile ValueWrapperManager.HandleBlockWeakReference[] handleBlockSharedMap = new ValueWrapperManager.HandleBlockWeakReference[0];
     public final ValueWrapperManager.HandleBlockAllocator handleBlockAllocator = new ValueWrapperManager.HandleBlockAllocator();
 
     @CompilationFinal public LanguageOptions options;

src/main/java/org/truffleruby/cext/ValueWrapperManager.java

@@ -139,9 +139,8 @@ private HandleBlock getBlockFromMap(int index, RubyLanguage language) {
         return ref.get();
     }
 
-    public void freeAllBlocksInMap(RubyLanguage language) {
+    public void freeAllBlocksInMap() {
         HandleBlockWeakReference[] map = blockMap;
-        HandleBlockAllocator allocator = language.handleBlockAllocator;
 
         for (HandleBlockWeakReference ref : map) {
             if (ref == null) {

src/main/java/org/truffleruby/collections/ConcurrentOperations.java

@@ -10,6 +10,7 @@
 package org.truffleruby.collections;
 
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
+import org.truffleruby.annotations.SuppressFBWarnings;
 
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -59,6 +60,7 @@ public static <K, V> boolean replace(Map<K, V> map, K key, V oldValue, V newValu
      * prefers the signal and just returns, it does {@code Thread.currentThread().interrupt()} to let us know there was
      * an interrupt too. In any case, if there was any interrupt we want to throw InterruptedException, regardless of
      * what the implementation prefers. */
+    @SuppressFBWarnings("WA_AWAIT_NOT_IN_LOOP")
     public static void awaitAndCheckInterrupt(Condition condition) throws InterruptedException {
         // Checkstyle: stop
         condition.await();

src/main/java/org/truffleruby/collections/IntHashMap.java

@@ -28,6 +28,8 @@
  ***** END LICENSE BLOCK *****/
 package org.truffleruby.collections;
 
+import org.truffleruby.annotations.SuppressFBWarnings;
+
 import java.util.AbstractSet;
 import java.util.Iterator;
 import java.util.NoSuchElementException;
@@ -228,6 +230,7 @@ public boolean hasNext() {
             return next != null;
         }
 
+        @SuppressFBWarnings("SA_FIELD_SELF_ASSIGNMENT")
         Entry<V> nextEntry() {
             Entry<V> e = next;
             if (e == null) {

src/main/java/org/truffleruby/collections/SharedIndicesMap.java

@@ -23,6 +23,7 @@
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.NeverDefault;
+import org.truffleruby.annotations.SuppressFBWarnings;
 
 /** An append-only map of names or identifiers to indices. The map is stored in {@link org.truffleruby.RubyLanguage} and
  * each {@link org.truffleruby.RubyContext} have separate {@link ContextArray}s. This enables looking up names and
@@ -93,6 +94,7 @@ protected T getSlowPath(int index) {
             }
         }
 
+        @SuppressFBWarnings("IS2_INCONSISTENT_SYNC")
         @TruffleBoundary
         public boolean contains(int index) {
             assert index <= sharedIndicesMap.size();

src/main/java/org/truffleruby/core/MarkingService.java

@@ -50,7 +50,7 @@ protected static final class ExtensionCallStackEntry {
         private CapturedException capturedException;
         private ValueWrapper markOnExitObject;
         private ArrayList<ValueWrapper> markOnExitObjects;
-        private Object[] marks;
+        private Object[] marks = null;
         private int marksIndex = 0;
 
         private ExtensionCallStackEntry(

src/main/java/org/truffleruby/core/TruffleSystemNodes.java

@@ -39,6 +39,7 @@
 package org.truffleruby.core;
 
 import java.io.IOException;
+import java.lang.invoke.VarHandle;
 import java.lang.management.ManagementFactory;
 import java.nio.file.NoSuchFileException;
 import java.util.Set;
@@ -51,6 +52,7 @@
 import com.sun.management.ThreadMXBean;
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.annotations.CoreMethod;
+import org.truffleruby.annotations.SuppressFBWarnings;
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.CoreMethodNode;
 import org.truffleruby.annotations.CoreModule;
@@ -281,14 +283,18 @@ protected int availableProcessors() {
 
     @CoreMethod(names = "allocated_bytes_of_current_thread", onSingleton = true)
     public abstract static class AllocatedBytesNode extends CoreMethodArrayArgumentsNode {
+
         private static ThreadMXBean bean;
 
+        @SuppressFBWarnings("LI_LAZY_INIT_STATIC")
         @TruffleBoundary
         @Specialization
         protected static long allocatedBytes() {
             if (bean == null) {
-                bean = (ThreadMXBean) ManagementFactory.getThreadMXBean();
-                bean.setThreadAllocatedMemoryEnabled(true);
+                var threadMXBean = (ThreadMXBean) ManagementFactory.getThreadMXBean();
+                threadMXBean.setThreadAllocatedMemoryEnabled(true);
+                VarHandle.storeStoreFence();
+                bean = threadMXBean;
             }
 
             return bean.getCurrentThreadAllocatedBytes();