Skip to content

OCI GenAI #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2024
Merged

OCI GenAI #43

merged 7 commits into from
Jun 17, 2024

Conversation

anders-swanson
Copy link
Member

No description provided.

Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 14, 2024
@anders-swanson anders-swanson changed the title Oci genai OCI GenAI Jun 14, 2024
markxnelson
markxnelson previously approved these changes Jun 14, 2024
Copy link
Member

@markxnelson markxnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick review, and looks good. have not done an exhaustive review yet.
a few notices wrong format or year

@@ -0,0 +1,62 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2023, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@@ -0,0 +1,55 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2023, Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@anders-swanson
Copy link
Member Author

Added documentation and updated for review comments.

Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anders-swanson anders-swanson merged commit 1f1d9a2 into main Jun 17, 2024
3 checks passed
@anders-swanson anders-swanson deleted the oci-genai branch June 17, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants