Skip to content

OKE Workload Identity Authentication #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

anders-swanson
Copy link
Member

No description provided.

Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 12, 2024
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@andytael andytael added the enhancement New feature or request label Jun 12, 2024
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
andytael
andytael previously approved these changes Jun 12, 2024
Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
Copy link
Member

@markxnelson markxnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

README.md Outdated
@@ -15,7 +15,9 @@ For a deep dive into the project, refer to the Spring Cloud OCI documentation:
| Version | Reference Docs | API Docs |
|------------------------|---------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------|
| Spring Cloud OCI 1.0.0 | [Reference Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/reference/html/index.html) | [API Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/javadocs/index.html) |
| Spring Cloud OCI 1.0.1 | [Reference Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/reference/html/index.html) | [API Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/javadocs/index.html)
| Spring Cloud OCI 1.0.1 | [Reference Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/reference/html/index.html) | [API Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/javadocs/index.html) |
| Spring Cloud OCI 1.1.0 | [Reference Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/reference/html/index.html) | [API Docs](https://oracle.github.io/spring-cloud-oci/1.0.0/javadocs/index.html) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we can add some more stuff, like adb, before we release 1.1.0, right, we revved to 1.1.0-SNAPSHOT, so i'd leave this line out until we do a release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@anders-swanson anders-swanson merged commit fce4a0b into oracle:main Jun 14, 2024
3 checks passed
@anders-swanson anders-swanson deleted the oke-workload-identity branch June 14, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants