do not log stack trace for CacheException reporting disabled cache an… #4597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes superfluous stack trace from the log entry in the case of disabled annotation cache by adding a property to
CacheException
and performing the logging based on this property.The alternative would be to change the code in
HistoryGuru#createAnnotationCache()
and avoid throwing the exception in such case however that would impact testability. Or, try to use a hack and set the elements of the exception object viasetStackTrace()
which seems fragile (if it actually works in this case).Example of the changed log entry:
While there, I fixed some related and not so related nits.