Fix wallet_location JSON Object handling #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
fmeheust
reviewed
Jun 3, 2025
| @@ -44,12 +44,15 @@ | |||
| import oracle.jdbc.spi.OracleConfigurationSecretProvider; | |||
| import oracle.sql.json.OracleJsonObject; | |||
|
|
|||
| import java.nio.charset.StandardCharsets; | |||
| import java.util.Base64; | ||
| import java.util.Map; | ||
|
|
||
| import static oracle.jdbc.provider.hashicorp.hcpvaultdedicated.authentication.DedicatedVaultParameters.FIELD_NAME; | ||
| import static oracle.jdbc.provider.hashicorp.hcpvaultdedicated.authentication.DedicatedVaultParameters.PARAMETER_SET_PARSER; | ||
| import static oracle.jdbc.provider.hashicorp.util.JsonUtil.extractSecret; | ||
| import static oracle.jdbc.provider.util.FileUtils.isBase64Encoded; |
| @@ -40,13 +40,16 @@ | |||
|
|
|||
| import oracle.jdbc.provider.hashicorp.hcpvaultsecret.secrets.HcpVaultSecretsManagerFactory; | |||
| import oracle.jdbc.provider.parameter.ParameterSet; | |||
| import oracle.jdbc.provider.util.FileUtils; | |||
fmeheust
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the
wallet_locationJSON object in Azure, HashiCorp (Vault Dedicated and Secrets), and AWS providers. It ensurescwallet.ssofiles are not encoded in Base64 twice and adds clear, comprehensive documentation for all providers (AWS, Azure, GCP, HashiCorp, OCI).