Extension restart fix #433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
requested changes
Jun 17, 2025
vscode/src/lsp/clientPromise.ts
Outdated
| import { LOGGER } from "../logger"; | ||
| import { NbProcessManager } from "./nbProcessManager"; | ||
| import { clientInit } from "./initializer"; | ||
| import { NbLanguageClient } from "./nbLanguageClient"; | ||
| import { globalState } from "../globalState"; | ||
| import { jdkDownloaderPrompt } from "../webviews/jdkDownloader/prompt"; |
| @@ -62,10 +64,15 @@ export class ClientPromise { | |||
| public restartExtension = async (nbProcessManager: NbProcessManager | null, notifyKill: boolean) => { | |||
| if (this.activationPending) { | |||
| LOGGER.warn("Server activation requested repeatedly, ignoring..."); | |||
| return; | |||
There was a problem hiding this comment.
Why this return statement is removed?
There was a problem hiding this comment.
- restartExtension gets triggered whenever the configurations are changed and in that case even if activationPending we would need to restart (as configs have changed).
- BTW this is linked with issue on windows, it gets stuck here because of the return statement sometimes . So to resolve that we need to remove this return and show the reload window to the user if required.
shivam71
force-pushed
the
extension-restart-fix-final
branch
from
84c1184 to
6ea48bc
Compare
Moved the reload window pop up from jdk downloader to configuration change listener(restartExtension) triggered whenever any configuration is changed and extension is in bad state.
shivam71
force-pushed
the
extension-restart-fix-final
branch
from
6ea48bc to
d3a16fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Post activating the extension one of the two cases happen
1)
JDK Found2)
No JDK FoundIn case of "No JDK Found" we enter a bad state where even if the user changes the jdk path to some valid path we cannot restart unless the user reloads .
In case initially JDK found but later user changes the path to an invalid jdk home then also we enter
No JDK Foundstate.Fix
Moved the reload window pop up from jdk downloader to configuration change listener(restartExtension) triggered whenever any configuration is changed and extension is in bad state.
This gives user a prompt to reload window so that extension can come out of the bad state.