Skip to content

Patch for the type name issue in change method parameter refactoring code action. #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

shivam71
Copy link
Member

  • ChangeMethodParametersRefactoring code action is used for changing the method signature .
  • This patch fixes the issue of using fully qualified names for the parameter types irrespective of what the user has written in the code .
  • The issue lead to annoying change of all the type names to fully qualified names whenever the ChangeMethodParametersRefactoring code action was triggered . Like String was converted to java.lang.String.
  • With this patch being applied the type name would be taken from the user code as is (verbatim) . So if the user has used simple type names they would be preserved .
  • Thanks to @lahodaj for providing this patch.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 24, 2025
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivam71 and @lahodaj. LGTM 👍

Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Achal1607 Achal1607 merged commit 757022e into oracle:main Apr 24, 2025
2 checks passed
@sid-srini sid-srini added this to the JVSC 24.1.0 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants