Skip to content

Backport patches of NB-26 #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

Achal1607
Copy link
Member

This PR aims to backport NB-26 patches which includes necessary bug fixes.

@Achal1607 Achal1607 requested a review from sid-srini March 4, 2025 09:34
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 4, 2025
@sid-srini sid-srini added this to the JVSC 24.0.0 milestone Mar 5, 2025
sid-srini
sid-srini previously approved these changes Mar 5, 2025
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lahodaj and @Achal1607 for bringing these important NBLS changes targeted for future NB releases. LGTM 👍
@Achal1607 - please merge #382 first and rebase on main before merging this. Thanks.

@Achal1607 Achal1607 force-pushed the upgrade-nb-25 branch 2 times, most recently from d2cc626 to 801b90f Compare March 7, 2025 09:08
@arvindaprameya arvindaprameya self-requested a review March 7, 2025 09:37
@arvindaprameya
Copy link
Member

LGTM, thank you

Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Achal1607 Achal1607 merged commit 2d7c06e into oracle:main Mar 7, 2025
3 checks passed
naren2605 added a commit to naren2605/javavscode that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants