[Ready to review] Refactoring SMC env variable config #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-shivam-ranjan
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
kumar-shivam-ranjan
changed the title
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
Jul 22, 2025
ads/aqua/config/container_config.py
Outdated
| for key, default in config_keys.items() | ||
| if key in additional_configurations | ||
| ] | ||
| env_vars_dict = json.loads( |
There was a problem hiding this comment.
For the transition period, I would support both. If we merge it as is and deploy without container changes, this will break the AQUA. We can add TODO indicating that the old logic needs to be deleted after the containers config related changes will be published.
There was a problem hiding this comment.
Updated.
Thanks!
mrDzurb
approved these changes
Jul 22, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
reviewed
Jul 22, 2025
prasankh
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to enhance the SMC environment variable configuration for AQUA. After this change, any new environment variable introduced as part of CP config should automatically be picked by ADS.
Related PR
https://bitbucket.oci.oraclecorp.com/projects/ODSC/repos/odsc-pegasus-control-plane/pull-requests/4689/overview
Unit tests
Test results
Was able to successfully deploy granite-vision model with the latest changes in this PR
