Skip to content

Reverting track md logs for error logging #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions ads/aqua/modeldeployment/deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,6 @@ def _create_deployment(
logger.info(
f"Aqua model deployment {deployment_id} created for model {aqua_model_id}. Work request Id is {deployment.dsc_model_deployment.workflow_req_id}"
)
status_list = []

progress_thread = threading.Thread(
target=self.get_deployment_status,
Expand Down Expand Up @@ -1316,45 +1315,24 @@ def get_deployment_status(
poll_interval=DEFAULT_POLL_INTERVAL,
)
except Exception:
status = ""
logs = deployment.show_logs().sort_values(by="time", ascending=False)

if logs and len(logs) > 0:
status = logs.iloc[0]["message"]

status = re.sub(r"[^a-zA-Z0-9]", " ", status)

if data_science_work_request._error_message:
error_str = ""
for error in data_science_work_request._error_message:
error_str = error_str + " " + error.message

error_str = re.sub(r"[^a-zA-Z0-9]", " ", error_str)
telemetry_kwargs = {
"ocid": ocid,
"model_name": model_name,
"work_request_error": error_str,
"status": status,
}

self.telemetry.record_event(
category=f"aqua/{model_type}/deployment/status",
action="FAILED",
**telemetry_kwargs,
)
else:
telemetry_kwargs = {
"ocid": ocid,
"model_name": model_name,
"status": status,
"work_request_error": error_str,
}

self.telemetry.record_event(
category=f"aqua/{model_type}/deployment/status",
action="FAILED",
**telemetry_kwargs,
)

else:
telemetry_kwargs = {"ocid": ocid, "model_name": model_name}
self.telemetry.record_event(
Expand Down
7 changes: 7 additions & 0 deletions docs/source/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
Release Notes
=============

2.13.14
-------
Release date: Jul 10, 2025

* Resolve issues with AQUA telemetry reporting


2.13.13
-------
Release date: Jul 10, 2025
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ build-backend = "flit_core.buildapi"

# Required
name = "oracle_ads" # the install (PyPI) name; name for local build in [tool.flit.module] section below
version = "2.13.13"
version = "2.13.14"

# Optional
description = "Oracle Accelerated Data Science SDK"
Expand Down
1 change: 0 additions & 1 deletion tests/unitary/with_extras/aqua/test_deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -2441,7 +2441,6 @@ def test_get_deployment_status_failed(self):
self.assertEqual(kwargs["category"], f"aqua/{model_type}/deployment/status")
self.assertEqual(kwargs["action"], "FAILED")
self.assertIn("work_request_error", kwargs)
self.assertIn("status", kwargs)
self.assertIn("ocid", kwargs)
self.assertIn("model_name", kwargs)

Expand Down