Skip to content

dropping support for py3.8 #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

dropping support for py3.8 #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccf1a8f
dropping support for py3.8
ahosler Feb 18, 2025
96ab51a
remove 3.8 workflow
ahosler Feb 18, 2025
a7a23cc
dropping py3.12 for now due to tensorflow res
ahosler Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...ub/workflows/run-unittests-py39-py310.yml → ...b/workflows/run-unittests-py310-py311.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "[Py3.9-3.11] - All Unit Tests"
name: "[Py3.10-3.11] - All Unit Tests"

on:
workflow_dispatch:
Expand Down Expand Up @@ -33,15 +33,14 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.10", "3.11"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 is removed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 is tested in the code coverage version.
This used to be 3.9-3.11, while code coverage was 3.8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

name: ["unitary", "slow_tests"]
include:
- name: "unitary"
test-path: "tests/unitary"
# `model` tests running in "slow_tests",
# `feature_store` tests has its own test suite
# `forecast` tests not supported in python 3.9,3.10 (automlx dependency). Tests are running in python3.8 test env, see run-unittests-py38-cov-report.yml
# 'pii' tests run only with py3.8, 'datapane' library conflicts with pandas>2.2.0, which used in py3.9/3.10 setup
# `forecast` tests not run in this suite
# 'hpo' tests hangs if run together with all unitary tests. Tests running in separate command before running all unitary
ignore-path: |
--ignore tests/unitary/with_extras/model \
Expand Down
8 changes: 4 additions & 4 deletions ...rkflows/run-unittests-py38-cov-report.yml → ...rkflows/run-unittests-py39-cov-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "[Py3.8][COV REPORT] - All Unit Tests"
name: "[Py3.9][COV REPORT] - All Unit Tests"

on:
workflow_dispatch:
Expand Down Expand Up @@ -26,7 +26,7 @@ env:

jobs:
test:
name: python 3.8, ${{ matrix.name }}
name: python 3.9, ${{ matrix.name }}
runs-on: ubuntu-latest
timeout-minutes: 90

Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: "3.8"
python-version: "3.9"
cache: "pip"
cache-dependency-path: |
pyproject.toml
Expand All @@ -71,7 +71,7 @@ jobs:
name: "Test env setup"
timeout-minutes: 30

# Installing pii deps for python3.8 test setup only, it will not work with python3.9/3.10, because
# Installing pii deps for python3.9 test setup only, it will not work with python3.9/3.10, because
# 'datapane' library conflicts with pandas>2.2.0, which used in py3.9/3.10 setup
- name: "Install PII dependencies"
run: |
Expand Down
14 changes: 5 additions & 9 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ classifiers = [
"Intended Audience :: Developers",
"License :: OSI Approved :: Universal Permissive License (UPL)",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -66,8 +65,7 @@ dependencies = [
"numpy>=1.19.2,<2.0.0",
"oci>=2.144.1",
"ocifs>=1.1.3",
"pandas>1.2.1; python_version<'3.9'", # starting pandas v2.1.0 requires-python = '>=3.9'
"pandas>=2.2.0; python_version>='3.9'",
"pandas>=2.2.0",
"psutil>=5.7.2",
"python_jsonschema_objects>=0.3.13",
"requests",
Expand Down Expand Up @@ -145,7 +143,7 @@ torch = [
"torchvision"
]
viz = [
"bokeh>=3.0.0,<3.2.0", # starting 3.2.0 bokeh not supporting python3.8; relax after ADS will drop py3.8 support
"bokeh",
"folium>=0.12.1",
"graphviz<0.17",
"scipy>=1.5.4",
Expand Down Expand Up @@ -203,7 +201,7 @@ pii = [
"scrubadub_spacy",
"spacy-transformers==1.2.5",
"spacy==3.6.1",
"report-creator>=1.0.32",
"report-creator>=1.0.37",
]
llm = ["langchain>=0.2", "langchain-community", "langchain_openai", "pydantic>=2,<3", "evaluate>=0.4.0"]
aqua = ["jupyter_server"]
Expand All @@ -227,10 +225,8 @@ testsuite = [
"pdfplumber",
"py4j",
"pyarrow>=15.0.0",
"statsmodels; python_version=='3.8'",
"statsmodels>=0.14.1; python_version>='3.9'", # cython3.0 compatibility added in v0.14.1
"tables",
"tables>3.9.0; python_version>='3.9'",
"statsmodels>=0.14.1",
"tables>3.9.0",
"xlrd>=1.2.0",
]

Expand Down